Skip to content

backport "Restore relevant cluster/scripts/ (#1032)" to 0.4.1 #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephencompall-DA merged 1 commit into from
Jun 10, 2025
Merged

backport "Restore relevant cluster/scripts/ (#1032)" to 0.4.1 #1064

stephencompall-DA merged 1 commit into from
Jun 10, 2025

Conversation

@stephencompall-DA
Copy link
Contributor

@stephencompall-DA stephencompall-DA commented Jun 10, 2025

Prerequisite to fix DACH-NY/cn-test-failures#4513.

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@martinflorian-da @stephencompall-DA
Restore relevant cluster/scripts/ (#1032) [static]
07297ab 
We still reference those in places, such as `cncluster` and CircleCI flows...

And they don't look secret to me; so let's push now to fix things and clean up later.

Fixes DACH-NY/cn-test-failures#4472

Signed-off-by: Martin Florian <[email protected]>
Signed-off-by: Stephen Compall <[email protected]>
@stephencompall-DA stephencompall-DA self-assigned this Jun 10, 2025
isegall-da
isegall-da approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@isegall-da isegall-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@stephencompall-DA stephencompall-DA enabled auto-merge (squash) June 10, 2025 21:39
@stephencompall-DA stephencompall-DA merged commit 5c3016c into release-line-0.4.1 Jun 10, 2025
39 checks passed
@stephencompall-DA stephencompall-DA deleted the s11/4513-backport-scripts-0.4.1 branch June 10, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isegall-da isegall-da isegall-da approved these changes

@ray-roestenburg-da ray-roestenburg-da Awaiting requested review from ray-roestenburg-da

@martinflorian-da martinflorian-da Awaiting requested review from martinflorian-da

Assignees

@stephencompall-DA stephencompall-DA

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stephencompall-DA @isegall-da @martinflorian-da